Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vt info to results #809

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

jjnicola
Copy link
Member

@jjnicola jjnicola commented Jul 26, 2021

DEPENDS on greenbone/gvm-libs#568

What:
Results format is changed and now include the fields

  • name, the script name
  • QoD, quality of detection
  • Score, calculated from the vector found in the vt.

Those fields are optional and will be added only if there is an OID

Why:
This task is done currently by ospd-openvas and must be moved to openvas.

How:

  • Use mosquitto_sub to subscribe the topic "scanner/results"
  • Run a small scan.
  • Check that results contains a severity, qod and name fields.
scanner/results {"scan_id":"829097a9-85d5-4bb8-bac0-e64c362b2836","type":"LOG","host_ip":"192.168.123.52","hostname":"192.168.0.1","port":"22/tcp","OID":"1.3.6.1.4.1.25623.1.0.90022","name":"SSH Authorization Check","qod":"80","severity":"0.0","value":"It was possible to login using the provided SSH credentials. Hence authenticated checks are enabled.\n","uri":""}

Checklist:

@jjnicola jjnicola requested a review from a team as a code owner July 26, 2021 07:09
@jjnicola jjnicola changed the title Results format is changed and now include the fields Add vt info to results Jul 26, 2021
@jjnicola jjnicola marked this pull request as draft July 26, 2021 09:23
- name, the script name
- QoD, quality of detection
- Score, calculated from the vector found in the vt.

Those fields are optional and will be added only if there is an OID
@jjnicola jjnicola force-pushed the results-nvti-info branch from 633a7c6 to ebe7080 Compare July 26, 2021 12:38
@jjnicola jjnicola force-pushed the results-nvti-info branch from ebe7080 to ce96a05 Compare July 26, 2021 12:39
@jjnicola jjnicola marked this pull request as ready for review July 26, 2021 13:06
CHANGELOG.md Outdated Show resolved Hide resolved
misc/nvt_qod.c Outdated Show resolved Hide resolved
misc/nvt_qod.c Outdated Show resolved Hide resolved
misc/nvt_qod.c Outdated Show resolved Hide resolved
misc/nvt_qod.c Outdated Show resolved Hide resolved
misc/nvt_qod.h Outdated Show resolved Hide resolved
misc/plugutils.c Show resolved Hide resolved
misc/plugutils.c Outdated Show resolved Hide resolved
misc/nvt_qod.c Outdated Show resolved Hide resolved
@jjnicola jjnicola force-pushed the results-nvti-info branch from 3df2ea5 to 7bb8129 Compare July 27, 2021 06:21
ArnoStiefvater
ArnoStiefvater previously approved these changes Jul 27, 2021
@ArnoStiefvater ArnoStiefvater merged commit e951952 into greenbone:middleware Aug 2, 2021
ArnoStiefvater added a commit to ArnoStiefvater/openvas that referenced this pull request Aug 11, 2021
@jjnicola jjnicola deleted the results-nvti-info branch September 6, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants